felipepessoto opened a new pull request, #13113:
URL: https://github.com/apache/gluten/pull/13113
<!--
Thank you for submitting a pull request! Here are some tips:
1. For first-time contributors, please read our contributing guide:
https://github.com/apache/gluten/blob/main/CONTRIBUTING.md
2. If necessary, create a GitHub issue for discussion beforehand to avoid
duplicate work.
3. If the PR is specific to a single backend, include [VL] or [CH] in the PR
title to indicate the
Velox or ClickHouse backend, respectively.
4. If the PR is not ready for review, please mark it as a draft.
-->
## What changes are proposed in this pull request?
<!--
Provide a clear and concise description of the changes introduced in this PR.
Ensure the PR description aligns with the code changes, especially after
updates.
If applicable, include "Fixes #<GitHub_Issue_ID>" to automatically close the
corresponding issue
when the PR is merged.
-->
Diagnostic draft related to #9003, using the explicitly requested
alternative to #13112. This is not a native IncrementMetric correctness fix and
does not resolve the issue.
Change exactly one literal in
`DeltaPostTransformRules.containsIncrementMetricExpr`:
```diff
- case e if e.prettyName == "increment_metric" => true
+ case e if e.prettyName == "increment_metric_dummy" => true
```
Real IncrementMetric expressions therefore no longer match this shared
recognition helper. `OffloadDeltaProject` and `OffloadDeltaFilter` retain their
implementations and registrations, including both calls in
`VeloxDeltaComponent`; their helper-based selection no longer recognizes the
real expression name. Native Delta scan registration and downstream
metric-update switches are unchanged. There are no configuration, baseline,
test-selection, quarantine, or native-semantics changes.
**Important scope caveat:** this matcher belongs to shared `gluten-delta`,
not only Velox. It also participates in `tagRowIndexRequiredSubtrees` and
`shouldPreserveDeletionVectorRowIndex`. Dummying the name removes the
IncrementMetric-specific row-index preservation signal as well as its
offload-recognition signal. Direct row-index-reference handling remains
unchanged. This is a minimal textual change, but it is **not guaranteed to be
semantically equivalent to #13112**, which removed only the two Velox offload
registrations.
This is an independent one-commit branch from `main` at
`8fa03c0fedf6cd7305526d4dfa759b0264eb99b0`, the same base used for the
completed #13112 comparison run; it is not stacked on #13112. The existing
draft and its branch are unchanged.
## How was this patch tested?
<!--
Describe how the changes were tested, if applicable.
Include new tests to validate the functionality, if necessary.
For UI-related changes, attach screenshots to demonstrate the updates.
-->
- Verified the complete diff is one file with one insertion and one
deletion, exactly the literal replacement above. `git diff --check` passes.
Both Velox offload registrations and the original license header are unchanged.
- Attempted `dev\format-scala-code.sh check` through Git Bash and the
repository Maven wrapper. It stopped because `JAVA_HOME`/a JDK is unavailable;
Scala formatting, compilation, and runtime tests were not completed locally.
- Attempted `dev\check.py header main --fix`; Windows Python is unavailable.
Retried the existing checker against the single changed file using WSL Python,
which stopped because this checkout lacks `dev\license-header.py`. The header
is unchanged.
- The existing upstream Delta Spark UT workflow is the intended diagnostic
coverage. Its pull-request path filter includes `gluten-delta/**` and does not
exclude drafts. No bespoke suite or native Spark build was added for this
one-literal experiment. This PR has no CI result yet.
**Reference only, not results for this PR:** #13112 at
`5e18f8d5b5cff3abeae1030fd09bf0f47d1787ae`, against the same base, completed
[Delta Spark UT run
35897644781](https://github.com/apache/gluten/actions/runs/35897644781) with
all eight shards and 19,121 executed tests: 225 baseline tests now passing
(31.4%), 491 still failing, zero regressions, and zero baseline skipped/stale.
That workflow concluded with failure. These earlier results must not be
attributed to this different experiment; its own CI is needed for comparison.
The known-failures baseline remains unchanged.
## Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this
patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling
Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
Generated-by: GitHub Copilot 1.0.87-0 (GPT-6 Astra, model ID: gpt-6-astra)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
