LuciferYang opened a new pull request, #13150:
URL: https://github.com/apache/gluten/pull/13150

   ## What changes are proposed in this pull request?
   
   `ShuffleManagerRouter`'s cache guarded a lookup miss with `assert(manager != 
null, "Shuffle manager not registered for shuffle id: ...")`. Spark launches 
executors without `-ea`, so the assertion is a no-op there, and a genuine cache 
miss surfaces as a bare `NullPointerException` at the delegation call site 
instead of the intended diagnostic. This replaces the assert with an explicit 
`null` check that throws a `GlutenException` carrying the shuffle id.
   
   Reachable only under the experimental `GlutenShuffleManager`, via the one 
public route (`shuffleBlockResolver.getBlockData`) that reads the cache without 
first registering the shuffle.
   
   ## How was this patch tested?
   
   `ShuffleManagerRouterCacheSuite` gains a case that resolves a block for a 
never-registered shuffle id and asserts the raised error names that shuffle id.
   
   ## Was this patch authored or co-authored using generative AI tooling?
   
   Yes. Generated-by: Claude Opus.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to