Copilot commented on code in PR #12625:
URL: https://github.com/apache/gluten/pull/12625#discussion_r4158108950
##########
dev/builddeps-veloxbe.sh:
##########
@@ -228,6 +242,10 @@ concat_velox_param
export VELOX_HOME
function build_arrow {
+ if vcpkg_is_active; then
+ echo "ERROR: build_arrow is deprecated with --enable_vcpkg=ON; Arrow is
managed by Gluten vcpkg." >&2
+ return 1
Review Comment:
This new hard failure breaks the still-active AlmaLinux vcpkg image:
`dev/docker/Dockerfile.almalinux8-gcc13-static-build:70-71` invokes this script
with `--enable_vcpkg=ON ... build_arrow`, so that Docker build now reaches this
branch and exits nonzero. The other static-image callers were migrated to
`populate-static-image-cache.sh`; update the AlmaLinux caller as well before
rejecting the legacy command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
