LuciferYang commented on PR #13100: URL: https://github.com/apache/gluten/pull/13100#issuecomment-5957203100
Closing after a second look. The existing guard already rejects every reachable case: GlutenShuffleManager itself and its supertypes (the ShuffleManager interface included) are caught, and the only real callers register ordinary ShuffleManager implementations (ColumnarShuffleManager from the Velox and Bolt listeners, SortShuffleManager at init). The sole gap this closed was registering a subclass of GlutenShuffleManager, which no backend does and which has no instance anywhere in the tree. That is validation hardening for a case that does not arise, not a fix for a reachable bug, so I would rather not carry it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
