LuciferYang commented on code in PR #13148:
URL: https://github.com/apache/gluten/pull/13148#discussion_r4178359168
##########
gluten-arrow/src/main/java/org/apache/gluten/vectorized/ColumnarBatchOutIterator.java:
##########
@@ -153,6 +153,12 @@ protected RuntimeException translateException(Exception e)
{
return schemaEx;
}
}
+ // A GlutenException raised by native/nested code is already translated;
return it
+ // as-is rather than nesting it in another GlutenException. The
schema-conversion
+ // special case above still runs first, so a schema error keeps its
dedicated type.
+ if (e instanceof GlutenException) {
Review Comment:
Thanks, added in 344937d43. The comment now says this check must stay after
every more specific translation, since a `GlutenException` subclass that needs
its own translation would otherwise come back untranslated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
