infvg commented on code in PR #13199:
URL: https://github.com/apache/gluten/pull/13199#discussion_r4186280675
##########
gluten-iceberg/src/main/scala/org/apache/gluten/execution/IcebergWriteExec.scala:
##########
@@ -130,7 +133,7 @@ trait IcebergWriteExec extends ColumnarV2TableWriteExec {
"Not support write unsupported partition type, or is nested
partition column")
}
}
- if (IcebergWriteUtil.getTable(write).sortOrder().isSorted) {
+ if (!supportsSortedWrite &&
IcebergWriteUtil.getTable(write).sortOrder().isSorted) {
Review Comment:
fixed, Changed validation to use getSortOrder(write).isSorted
##########
docs/get-started/VeloxIceberg.md:
##########
@@ -30,17 +30,28 @@ Fallback
Fallback
## Writing
-Fallback
+Supported Parquet writes can offload when
+`spark.gluten.sql.enable.enhancedFeatures` and
+`spark.gluten.sql.columnar.iceberg.enableNativeWrite` are enabled.
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
