philo-he commented on code in PR #13208:
URL: https://github.com/apache/gluten/pull/13208#discussion_r4203547934
##########
gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/EliminateLocalSort.scala:
##########
@@ -20,7 +20,7 @@ import org.apache.gluten.execution.{ProjectExecTransformer,
ShuffledHashJoinExec
import org.apache.spark.sql.catalyst.expressions.SortOrder
import org.apache.spark.sql.catalyst.rules.Rule
-import org.apache.spark.sql.execution.{ProjectExec, SortExec, SparkPlan,
UnaryExecNode}
+import org.apache.spark.sql.execution.{OrderPreservingNodeShim, ProjectExec,
SortExec, SparkPlan, UnaryExecNode}
Review Comment:
A separate minor issue:
`trait OrderPreservingNodeShim extends OrderPreservingUnaryExecNode` is now
identical across all supported Spark versions (3.4 through 4.2), since the shim
no longer bridges any version difference. Given that, do we still need
`OrderPreservingNodeShim` at all? If not, could we clean it up in this PR,
since it's only a small removal?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
