akshaytayal commented on code in PR #13163: URL: https://github.com/apache/gluten/pull/13163#discussion_r4236483655
########## backends-velox/src/test/scala/org/apache/gluten/execution/MiscOperatorSuite.scala: ########## @@ -37,6 +37,11 @@ import java.util.concurrent.TimeUnit import scala.collection.JavaConverters import scala.collection.JavaConverters._ +// GLUTEN-12569 Spark 4.2 UT enablement: disabled whole suite - beforeAll registers the +// 1-part FunctionIdentifier "velox_dummy_expression" (VeloxDummyExpression.registerFunctions), +// which Spark 4.2's FunctionRegistry rejects (must be fully-qualified 3-part), aborting the +// entire group1 CI run. Disabled here so the rest of the group can run and be triaged. [email protected] Review Comment: Thanks. Fixed in 743714330: - Removed the class-level `@org.scalatest.Ignore` from both suites. - Added your suggested `tags` override (Spark 4.2 only) with the GLUTEN-13179 note. CI for this commit, group 1: https://github.com/apache/gluten/actions/runs/37891227655 - Spark 3.5: `MiscOperatorSuite` 98 passed, `GlutenBloomFilterFallbackSuite` 7 passed - Spark 4.1: `MiscOperatorSuite` 99 passed, `GlutenBloomFilterFallbackSuite` 8 passed - Spark 4.2: all 108 tests ignored, no setup abort - Spark 3.4 and 4.0: green `MiscOperatorSuite` also has 1 ignored test on 3.5/4.1, the same as on main. On 4.2 every test is ignored, so `beforeAll` never runs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
