ReemaAlzaid commented on PR #13183: URL: https://github.com/apache/gluten/pull/13183#issuecomment-6150881486
The latest [CI failure](https://github.com/apache/gluten/actions/runs/38414120107/job/115353854846) occurs while compiling the shared `produce()` helper in [KafkaConnectorTest.cc, lines 66–67](https://github.com/apache/gluten/blob/386cdc890dfa7d3774b9326b40a55c834cd72601/cpp/velox/tests/KafkaConnectorTest.cc#L59-L71), before any test runs. The `RD_KAFKA_V_KEY` and `RD_KAFKA_V_VALUE` macros cast their arguments without parentheses, so the conditional expressions also need parentheses. The earlier `StringView` fix is working: this run compiled `KafkaDataSource.cc` and linked `libvelox.so` successfully. The existing ownership test is [`KafkaConnectorTest.exclusiveOffsetsAndProjectedBinaryRows`](https://github.com/apache/gluten/blob/386cdc890dfa7d3774b9326b40a55c834cd72601/cpp/velox/tests/KafkaConnectorTest.cc#L120-L161). It checks the projected topic at line 140 after the polled messages have been destroyed. The native connector test suite remains enabled. The workflow also prematurely enabled tests that are absent from this connector-only branch: - Kafka plan-conversion tests belong to the later `kafka-substrait` branch. - `VeloxKafkaScanValidationSuite` and `VeloxGlutenKafkaScanSuite` belong to the later `kafka-microbatch-offload` branch. The prepared local patch fixes the macro arguments and restores `main`’s existing TODO/commented state for those future test steps, while retaining the native connector tests and Spark 3.5 packaging. These changes have not been pushed yet. The corrected helper passes focused compilation with Clang and GCC against librdkafka 2.13.0; full native test execution still needs CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
