Copilot commented on code in PR #13320:
URL: https://github.com/apache/gluten/pull/13320#discussion_r4280814513
##########
backends-velox/src/main/scala/org/apache/spark/rpc/GlutenDriverEndpoint.scala:
##########
@@ -116,8 +116,9 @@ object GlutenDriverEndpoint extends Logging
.build[String, util.Set[String]]()
def collectResources(executionId: String, resourceId: String): Unit = {
+ // Broadcast plans can register resources concurrently on driver threads.
val resources = executionResourceRelation
Review Comment:
This file previously used `util.HashSet` (suggesting an `import
java.util.{... => util}` style). To keep imports/qualification consistent and
avoid any ambiguity with other `ConcurrentHashMap` symbols, consider either
fully-qualifying this reference
(`java.util.concurrent.ConcurrentHashMap.newKeySet[String]()`), or introducing
an explicit import/alias that matches the existing pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
