LuciferYang opened a new pull request, #13331:
URL: https://github.com/apache/gluten/pull/13331
## What changes are proposed in this pull request?
Since #10774, `SharedLibraryLoaderCentos7` and `SharedLibraryLoaderCentos8`
match TencentOS with `osName.contains("tencentos")`, where `osName` is the
`NAME` field of `/etc/os-release`. TencentOS Server reports `NAME="TencentOS
Server"`, so the check never matches, and with
`spark.gluten.loadLibFromJar=true` loading fails with "Cannot find
SharedLibraryLoader". Before #10774 the check ran on the whole os-release text
and matched `ID="tencentos"`.
This lowercases the name with `Locale.ROOT` before the check, in the Velox
and Bolt copies of both loaders. The version checks are unchanged: 2.4 goes to
the centos7 loader and 3.2 to the centos8 loader, and no other registered
loader accepts the TencentOS name.
## How was this patch tested?
Added `SharedLibraryLoaderCentosSuite`, which checks both loaders against
the `NAME` and `VERSION` values TencentOS Server 2.4 and 3.2 report: each
version is accepted by exactly one loader, and 3.1 and 4.2 are rejected. The
first case fails without this change. The Bolt copies get the same one-line
change and compile, but no test or CI job covers backends-bolt.
## Was this patch authored or co-authored using generative AI tooling?
Yes. Generated-by: Claude Opus.
Related issue: #13329.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
