jinchengchenghh commented on code in PR #13224:
URL: https://github.com/apache/gluten/pull/13224#discussion_r4284429617
##########
backends-velox/pom.xml:
##########
@@ -581,6 +632,114 @@
<scope>test</scope>
</dependency>
</dependencies>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-antrun-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>compile-iceberg-coverage-listener</id>
+ <goals>
+ <goal>run</goal>
+ </goals>
+ <phase>process-test-classes</phase>
+ <configuration>
+ <target>
+ <!-- Compile only the observer and its tests, without
copied upstream classes. -->
+ <mkdir dir="${iceberg.upstream.test.classes}"/>
+ <!-- Some upstream tests resolve classpath fixtures as
filesystem paths. -->
+ <unzip dest="${iceberg.upstream.test.classes}">
+ <restrict>
+ <path refid="maven.test.classpath"/>
+ <name name="**/org/apache/iceberg/*-tests.jar"/>
+ </restrict>
+ <patternset
excludes="**/*.class,META-INF/**,LICENSE,NOTICE,iceberg-build.properties"/>
+ </unzip>
+ <javac destdir="${iceberg.upstream.test.classes}"
encoding="UTF-8" includeantruntime="false" release="17">
+ <src
path="${project.basedir}/src-iceberg-upstream/test/java"/>
+ <src
path="${project.basedir}/../gluten-ut/src-iceberg-upstream/test/java"/>
+ <classpath refid="maven.test.classpath"/>
+ </javac>
+ <copy todir="${iceberg.upstream.test.classes}">
+ <fileset
dir="${project.basedir}/src-iceberg-upstream/test/resources"/>
+ </copy>
+ </target>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>iceberg-upstream</id>
+ <configuration>
+ <!-- Only the coverage listener is shared with the unchanged
upstream tests. -->
+
<testClassesDirectory>${iceberg.upstream.test.classes}</testClassesDirectory>
+ <classpathDependencyExcludes>
+
<classpathDependencyExclude>org.apache.iceberg:iceberg-spark-runtime-*</classpathDependencyExclude>
+
<classpathDependencyExclude>org.apache.avro:avro</classpathDependencyExclude>
+
<classpathDependencyExclude>org.apache.parquet:*</classpathDependencyExclude>
+
<classpathDependencyExclude>org.apache.datasketches:*</classpathDependencyExclude>
+
<classpathDependencyExclude>org.apache.orc:orc-core</classpathDependencyExclude>
+
<classpathDependencyExclude>org.apache.orc:orc-shims</classpathDependencyExclude>
+
<classpathDependencyExclude>org.mockito:*</classpathDependencyExclude>
+
<classpathDependencyExclude>net.bytebuddy:*</classpathDependencyExclude>
+
<classpathDependencyExclude>org.objenesis:*</classpathDependencyExclude>
+ </classpathDependencyExcludes>
+ <!-- Use Iceberg's Avro, Parquet, DataSketches and nohive
ORC runtime. -->
+ <additionalClasspathDependencies>
+ <dependency>
+ <groupId>org.apache.iceberg</groupId>
+
<artifactId>iceberg-spark-${sparkbundle.version}_${scala.binary.version}</artifactId>
+ <version>${iceberg.version}</version>
+ </dependency>
+ <!-- Iceberg 1.10/1.11 use Mockito 4.11, including static
mocks. -->
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-inline</artifactId>
+ <version>4.11.0</version>
+ </dependency>
+ </additionalClasspathDependencies>
+ <dependenciesToScan>
+
<dependency>org.apache.iceberg:iceberg-spark-${sparkbundle.version}_${scala.binary.version}:test-jar:tests</dependency>
+
<dependency>org.apache.iceberg:iceberg-spark-extensions-${sparkbundle.version}_${scala.binary.version}:test-jar:tests</dependency>
+ </dependenciesToScan>
+ <!-- JUnit discovers tests in every upstream class,
including inherited tests. -->
+ <includes>
+ <include>org/apache/iceberg/**/*.class</include>
+ </includes>
+ <failIfNoTests>true</failIfNoTests>
+ <failIfNoSpecifiedTests>true</failIfNoSpecifiedTests>
+ <forkCount>${iceberg.upstream.forks}</forkCount>
+ <reuseForks>false</reuseForks>
+
<forkedProcessTimeoutInSeconds>2400</forkedProcessTimeoutInSeconds>
+
<reportsDirectory>${iceberg.upstream.reports}</reportsDirectory>
+ <redirectTestOutputToFile>true</redirectTestOutputToFile>
+ <argLine>${argLine} ${extraJavaTestArgs} -Xmx2g</argLine>
+ <systemPropertyVariables>
+
<iceberg.upstream.shard>${iceberg.upstream.shard}</iceberg.upstream.shard>
+
<iceberg.upstream.shards>${iceberg.upstream.shards}</iceberg.upstream.shards>
+
<spark.plugins>org.apache.gluten.GlutenPlugin</spark.plugins>
Review Comment:
Does SparkConf read these system properties, such as
`spark.memory.offHeap.enabled`? Also, based on the logs, can we confirm that
Gluten is actually being executed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
