malinjawi opened a new pull request, #13336:
URL: https://github.com/apache/gluten/pull/13336

   ## What changes are proposed in this pull request?
   
   Fixes #13290.
   
   #13289 removed the CentOS 7 Dockerfiles, `setup-centos7.sh` and the 
`vcpkg-centos-7-gcc13` image job, but left references behind: on main, 
`build-helper-functions.sh` still calls `setup-centos7.sh` in three places and 
`LICENSE` still lists it. This removes the rest:
   
   - Remove the CentOS 7 branches from `build-helper-functions.sh`, 
`get-velox.sh`, `build-thirdparty.sh` and `package-vcpkg.sh`, and 
`install_centos_7` from `vcpkg/setup-build-depends.sh`.
   - Delete `dev/ci-velox-buildstatic-centos-7*.sh` (no workflow calls them) 
and `dev/install-linux-socket-header.sh`, which only the CentOS 7 static build 
used (#12768).
   - Delete the `centos:7` dev container (`dev/docker/Dockerfile`, 
`entrypoint.sh`, `dev/.dockerignore`) and its Makefile targets.
   - Drop the `setup-centos7.sh` entry from `LICENSE` and the dead `centos:7` 
check in `velox_backend_x86.yml`.
   - Point the docs and the benchmark build script at 
`apache/gluten:vcpkg-almalinux-8-gcc13`, the image the release workflow already 
uses.
   
   Alibaba Cloud Linux 2 and TencentOS 2.4 are CentOS 7 based and also ran 
`setup-centos7.sh`, so their branches go too. On main they already fail on the 
missing script.
   
   `SharedLibraryLoaderCentos7` is runtime code rather than a script, so it's 
left for a follow-up.
   
   ## How was this patch tested?
   
   - `bash -n` on every edited script, the workflow YAML parses, and the 
license header check passes.
   - No remaining references to any deleted file.
   - Ran main's and this branch's OS dispatch in `build-helper-functions.sh`, 
`get-velox.sh`, `build-thirdparty.sh`, `package-vcpkg.sh` and 
`setup-build-depends.sh` against stubbed `/etc/os-release` files for 18 OS 
versions. Every supported OS picks the same setup step as before. Only CentOS 
7, Alibaba Cloud Linux 2 and TencentOS 2.4 change, from "No such file" / 
"command not found" to "Unsupported ... version".
   
   ## Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: IBM Bob
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to