baibaichen commented on code in PR #13168: URL: https://github.com/apache/gluten/pull/13168#discussion_r4301680577
########## cpp/core/CMakeLists.txt: ########## @@ -251,11 +254,12 @@ if(BUILD_TESTS) add_subdirectory(tests) endif() -target_link_libraries(gluten PUBLIC Arrow::arrow) +target_link_libraries(gluten_core_impl PUBLIC Arrow::arrow) if(NOT ENABLE_GLUTEN_VCPKG) - target_link_libraries(gluten PUBLIC Arrow::arrow_bundled_dependencies) + target_link_libraries(gluten_core_impl + PUBLIC Arrow::arrow_bundled_dependencies) endif() -target_link_libraries(gluten PRIVATE glog::glog) +target_link_libraries(gluten_core_impl PRIVATE glog::glog) Review Comment: Both the vcpkg build and the non-vcpkg CentOS 9 build passed locally, including compilation of `JniWrapper.cc`. In these environments, glog headers are available through the shared dependency include directory or `/usr/local/include`. This does not rule out the separate-prefix case you describe. We have not reproduced that configuration yet, so this is currently a potential portability issue rather than an observed build failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
