malinjawi opened a new pull request, #13356: URL: https://github.com/apache/gluten/pull/13356
## What changes are proposed in this pull request? CI's clang-tidy step lints every file a PR touches, so any change to `WholeStageResultIterator` shows these five warnings (they came up on #13165): - `spillDir` is passed by const reference instead of by value. - `projectSource` is bound by reference instead of copying the `shared_ptr`. - The partial aggregation memory limits use `value_or` instead of `has_value()` followed by `value()`. - The destructor now catches and logs a failure to cancel or wait for the Velox task. Before, such an exception would call `std::terminate`. Nothing else changes. ## How was this patch tested? Existing native tests in CI. clang-format-15 clean. ## Was this patch authored or co-authored using generative AI tooling? Generated-by: IBM Bob -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
