rdtr opened a new pull request, #13371:
URL: https://github.com/apache/gluten/pull/13371
## What changes are proposed in this pull request?
Fixes #13275.
The test jobs in `velox_backend_ansi.yml` check out
`needs.check-comment.outputs.pr_sha`, but they only list `build-native-lib` in
`needs`:
```yaml
spark-test-backends-velox-ansi41:
needs: build-native-lib
...
- uses: actions/checkout@v7
with:
ref: ${{ needs.check-comment.outputs.pr_sha }}
```
The `needs` context only has the outputs of the jobs listed directly in
`needs`, so `needs.check-comment` is not there and `pr_sha` is empty. With an
empty `ref`, `actions/checkout` checks out the default ref of the event, which
is the default branch for `issue_comment`. So the native library was built from
the PR (in `build-native-lib`, which does list `check-comment`), but the tests
ran the code of main. This matches the run in #13275, which checked out main at
cc011f37.
This PR adds `check-comment` to `needs` of the four test jobs:
- `spark-test-backends-velox-ansi41`
- `spark-test-spark-ut-ansi41`
- `spark-test-backends-velox-ansi-spark40`
- `spark-test-spark-ut-ansi-spark40`
`analyze-results` and `analyze-only` already list `check-comment`.
## How was this patch tested?
I checked that the YAML still parses and that every job that reads
`needs.check-comment.outputs` now lists `check-comment` in `needs`. A workflow
started by `issue_comment` always uses the workflow file from the default
branch, so this change can only be checked with `/ansi-test` on a PR after it
is merged.
## Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
