Copilot commented on code in PR #13372:
URL: https://github.com/apache/gluten/pull/13372#discussion_r4319729843
##########
tools/scripts/diff-function-support-docs.py:
##########
@@ -46,7 +46,7 @@ def header(text):
for cat in ["scalar", "aggregate", "window", "generator"]:
- path = f"docs/velox-backend-{cat}-function-support.md"
+ path = f"docs/backends/velox/velox-backend-{cat}-function-support.md"
old_text = subprocess.run(
["git", "show", f"{REV}:{path}"], capture_output=True, text=True
).stdout
Review Comment:
When `REV` predates this move, the document exists only at
`docs/velox-backend-{cat}-function-support.md`. The new `git show` lookup
fails, but its empty stdout is treated as the old document. This reports every
existing function as `NEW` and hides actual status and restriction changes.
Keep the new working-tree path, fall back to the legacy path for historical
revisions, and fail explicitly if neither lookup succeeds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
