ReemaAlzaid commented on code in PR #13236:
URL: https://github.com/apache/gluten/pull/13236#discussion_r4328989933
##########
cpp/velox/compute/VeloxRuntime.cc:
##########
@@ -404,9 +404,9 @@ void VeloxRuntime::parseSplitInfo(const uint8_t* data,
int32_t size, int32_t spl
LOG(WARNING) << "Error converting substrait::ReadRel.LocalFiles to JSON:
" << e.what();
}
}
- ::substrait::ReadRel_LocalFiles localFile;
- GLUTEN_CHECK(parseProtobuf(data, size, &localFile) == true, "Parse substrait
plan failed");
- localFiles_.push_back(localFile);
+ // The matching ReadRel determines whether these bytes encode LocalFiles or
StreamKafka.
+ // Decode them during plan conversion, after the scan type is known.
+ rawSplitInfos_.emplace_back(reinterpret_cast<const char*>(data), size);
Review Comment:
yeah we could, I changed it to parse file and kafka splits and store them
like this `SplitInfo` or `KafkaSplitInfo`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
