rdtr opened a new pull request, #13400: URL: https://github.com/apache/gluten/pull/13400
## What changes are proposed in this pull request? Related to #11088. Some tests are still excluded for Spark 4.0, 4.1 and 4.2 with a TODO, but they pass on the current main. This PR removes those excludes: | Suite | Test | Spark versions | | --- | --- | --- | | `GlutenCreateTableAsSelectSuite` | `CREATE TABLE USING AS SELECT based on the file without write permission` | 4.0, 4.1, 4.2 | | `GlutenCreateTableAsSelectSuite` | `create a table, drop it and create another one with the same name` | 4.0, 4.1, 4.2 | | `GlutenCastWithAnsiOffSuite` | `SPARK-39749: cast Decimal to string` | 4.0, 4.1, 4.2 | | `GlutenVariantSuite` | `SPARK-47546: valid variant binary` | 4.1, 4.2 | Excludes that stay: - `SPARK-39749` in `GlutenTryCastSuite` still fails. With ANSI on (and in `try_cast`), Spark writes the decimal as `0.000000123`, but Velox writes `1.23E-7`. With ANSI off, Spark also writes `1.23E-7`, which is why the `GlutenCastWithAnsiOffSuite` test passes. - `SPARK-47546: valid variant binary` still fails on Spark 4.0. Velox writes the variant struct fields as OPTIONAL, and the Spark 4.0 reader rejects the file. Spark 4.1 and 4.2 accept it. `invalid variant binary` still fails on all versions for the same reason. ## How was this patch tested? Ran `GlutenCastWithAnsiOffSuite`, `GlutenCreateTableAsSelectSuite` and `GlutenVariantSuite` locally on Spark 4.0 (4.0.2), 4.1 (4.1.1) and 4.2 (4.2.0). All re-enabled tests pass. The only failure is `SPARK-35719: cast timestamp with local time zone to timestamp without timezone`, which this PR does not touch. It is not excluded and passes in CI, so it looks like a problem with my local time zone setup. ## Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Code (Claude Opus 5.5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
