hhr293 commented on code in PR #13363:
URL: https://github.com/apache/gluten/pull/13363#discussion_r4344917832
##########
cpp/core/utils/tac/ffor.hpp:
##########
@@ -280,23 +280,22 @@ inline void decodeRt(const uint64_t* in, uint64_t* out,
uint64_t base, size_t n,
detail::kDecodeTable[bw](in, out, base, n);
}
+namespace detail {
+// Minimum and maximum of data[0, n); requires n > 0. Defined in
FForCodec.cc, where it is
+// multiversioned for x86-64-v4 (AVX2 has no unsigned 64-bit min/max).
+void minMaxScan(const uint64_t* data, size_t n, uint64_t& mn, uint64_t& mx);
Review Comment:
Intentional: defining the multiversioned function in the header made every
including TU emit its own clones and resolver (see the inline thread).
`ffor.hpp` is only included by `FForCodec.cc`, which is compiled into
`gluten_core_impl` and so into `libgluten`; `FForCodecTest` links
`gluten_core_impl` directly. The declaration comment now says callers must link
`FForCodec.cc`. Symbol visibility is tracked in the separate thread below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
