malinjawi commented on PR #12647: URL: https://github.com/apache/gluten/pull/12647#issuecomment-6345568537
@felipepessoto thanks for the thorough review, and sorry it took a while to get back to this. I merged main (the 4.x side now lives in `src-delta4` after #13271) and addressed all five comments; replies are inline. CI is green, including the Delta UT gate with no regressions. Ready for another look whenever you have time. cc @zhztheplayer, since you asked on #12030 why this isn't an offloaded expression. The design note in the description covers that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
