jinchengchenghh commented on code in PR #12726: URL: https://github.com/apache/gluten/pull/12726#discussion_r4357554128
########## gluten-substrait/src/main/scala/org/apache/gluten/execution/BasicScanExecTransformer.scala: ########## @@ -115,6 +116,9 @@ trait BasicScanExecTransformer extends LeafTransformSupport with BaseDataSource def getInputStats: Option[InputStats] = Option.empty + /** Names of the real columns this scan reads from the source, as opposed to injected ones. */ Review Comment: Please remove readColumnNames, override neededInputFileRelatedMetadataKeys in FileSourceScanExecTransformer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
