malinjawi commented on code in PR #13357:
URL: https://github.com/apache/gluten/pull/13357#discussion_r4365734425
##########
cpp/velox/compute/WholeStageResultIterator.h:
##########
@@ -136,6 +136,9 @@ class WholeStageResultIterator : public
SplitAwareColumnarBatchIterator {
std::unique_ptr<facebook::velox::exec::TaskCursor> cursor_;
facebook::velox::exec::Task* task_ = nullptr;
std::shared_ptr<const facebook::velox::core::PlanNode> veloxPlan_;
+ /// Whether the plan calls a Delta counter and so needs the query configs
set by
+ /// setIncrementMetricQueryConfigs().
+ const bool trackExpressionStats_;
Review Comment:
Makes sense, renamed to usesIncrementMetricFunctions_ in f5248ebfd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
