ggjh-159 commented on code in PR #13375:
URL: https://github.com/apache/gluten/pull/13375#discussion_r4377305267
##########
gluten-flink/planner/src/main/java/org/apache/gluten/rexnode/RexNodeConverter.java:
##########
@@ -97,7 +97,38 @@ public static Type toType(RelDataType relDataType) {
return
LogicalTypeConverter.toVLType(FlinkTypeFactory.toLogicalType(relDataType));
}
+ private static Variant toNullVariant(SqlTypeName sqlTypeName) {
+ // A typed null needs no per-type carrier: the velox-side
+ // ConstantTypedExpr renders a null variant as a null constant of the
+ // EXPRESSION type (the variant kind is irrelevant on the null path), and
+ // the velox variant serde treats an absent "value" member as the typed
+ // null (matching velox4j's Include.NON_NULL serialization). VarCharValue
+ // is the natural null-accepting carrier.
+ switch (sqlTypeName) {
Review Comment:
The toNullVariant switch is missing DATE: IFNULL(date_col, NULL) /
IFNULL(NULL, date_col) fails at job construction with "Unsupported null rex
node type: DATE". Please add the DATE case (and INTERVAL_SECOND / SYMBOL, which
the main switch handles but the null path does not).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
