rui-mo commented on code in PR #13441:
URL: https://github.com/apache/gluten/pull/13441#discussion_r4384839849
##########
backends-velox/src/main/scala/org/apache/gluten/execution/HashAggregateExecTransformer.scala:
##########
@@ -504,7 +508,13 @@ abstract class HashAggregateExecTransformer(
val aggregateFunc = aggExpr.aggregateFunction
val childrenNodes = aggExpr.mode match {
case Partial | Complete =>
- aggregateFunc.children.toList.map(toExpressionNode)
+ VeloxIntermediateData.getRawInputs(aggregateFunc).toList.map {
+ case literal: Literal if rowConstructed =>
Review Comment:
Thanks @akshaytayal for clarifying. It would be helpful to add a comment to
explain that rowConstructed can affect Partial for mixed-phased aggregates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
