ggjh-159 commented on code in PR #13455:
URL: https://github.com/apache/gluten/pull/13455#discussion_r4386105826
##########
gluten-flink/planner/src/main/java/org/apache/gluten/rexnode/RexNodeConverter.java:
##########
@@ -138,6 +138,10 @@ public static Variant toVariant(RexLiteral literal) {
long epochMillis = literal.getValueAs(Long.class);
return TimestampValue.create(
Math.floorDiv(epochMillis, 1000L), Math.floorMod(epochMillis,
1000L) * 1_000_000L);
+ case TIME:
Review Comment:
The testing section lists 'TIME in the typed-null carrier list', but the PR
adds no code or test for TIME typed nulls — a TIME null literal still fails to
convert (the millis-of-day IntegerValue wraps a primitive int, so a null
unboxes to an NPE). Please drop that claim or cover TIME typed nulls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
