This is an automated email from the ASF dual-hosted git repository.
marin-ma pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gluten.git
The following commit(s) were added to refs/heads/main by this push:
new 0c322e8588 [MINOR][VL] Fix integer overflow in shuffle buffer offsets
and shrink size (#13448)
0c322e8588 is described below
commit 0c322e85884d2ed5d65e10d64f2f87759e997ed3
Author: Zhang Xiaofeng <[email protected]>
AuthorDate: Tue Oct 27 20:11:05 2026 +0800
[MINOR][VL] Fix integer overflow in shuffle buffer offsets and shrink size
(#13448)
---
cpp/velox/shuffle/VeloxHashShuffleWriter.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/cpp/velox/shuffle/VeloxHashShuffleWriter.cc
b/cpp/velox/shuffle/VeloxHashShuffleWriter.cc
index 14c55861bc..242683450c 100644
--- a/cpp/velox/shuffle/VeloxHashShuffleWriter.cc
+++ b/cpp/velox/shuffle/VeloxHashShuffleWriter.cc
@@ -1298,7 +1298,7 @@ arrow::Status
VeloxHashShuffleWriter::resizePartitionBuffer(uint32_t partitionId
binaryBuf.lengthPtr = lengthBuffer->mutable_data();
break;
}
- auto valueOffset = 0;
+ uint64_t valueOffset = 0;
// If preserve data, the new valueBufferSize should not be smaller
than the current offset.
if (preserveData) {
valueBufferSize = std::max(binaryBuf.valueOffset, valueBufferSize);
@@ -1513,7 +1513,7 @@ arrow::Result<int64_t>
VeloxHashShuffleWriter::shrinkPartitionBuffersMinSize(int
std::sort(pidToSize.begin(), pidToSize.end(), [&](const auto& a, const auto&
b) { return a.second > b.second; });
auto beforeShrink = partitionBufferPool_->bytes_allocated();
- auto shrunken = 0;
+ int64_t shrunken = 0;
auto iter = pidToSize.begin();
// Shrink in order to reclaim the largest amount of space with fewer resizes.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
