sabbasani commented on code in PR #13319:
URL: https://github.com/apache/gluten/pull/13319#discussion_r4397765487
##########
gluten-ut/spark35/src/test/scala/org/apache/gluten/utils/clickhouse/ClickHouseTestSettings.scala:
##########
@@ -1201,6 +1201,7 @@ class ClickHouseTestSettings extends BackendTestSettings {
.excludeCH("atan2")
.excludeCH("SPARK-42045: integer overflow in round/bround")
.excludeCH("Gluten - round/bround/floor/ceil")
+ .excludeGlutenTest("unhex")
Review Comment:
Thanks, good catch. Done in d8d36f0e2. I moved the "GG" and "δΈιη" assertions
into a separate testGluten("unhex returns null for invalid hex input") in
spark34/35/40/41. CH now excludes only that case (with a pointer to #7232), so
Gluten - unhex keeps its valid-input assertions on CH and Velox still checks
the null cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
