lgbo-ustc commented on code in PR #13334:
URL: https://github.com/apache/gluten/pull/13334#discussion_r4420415291
##########
gluten-substrait/src/main/resources/substrait/proto/substrait/algebra.proto:
##########
@@ -251,6 +251,12 @@ message ReadRel {
}
message PaimonReadOptions {
+ message PaimonCppSplit {
Review Comment:
Could we give this message an implementation-neutral name? It carries a
serialized Paimon DataSplit together with the table path, branch, and read
options; nothing in the wire format is C++-specific. `PaimonCppSplit` (and
`cpp_split` below) couples the shared Substrait protocol to the current reader
implementation and may be misleading for other consumers. Something like
`PaimonSplitReadSpec` / `split_read_spec` would describe the payload more
accurately; the field number can remain 10.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
