pedrumj2 opened a new pull request, #13511: URL: https://github.com/apache/gluten/pull/13511
## What changes are proposed in this pull request? - facebookincubator/velox#17669 added `transform_values` to Velox's Spark functions ([RegisterMap.cpp](https://github.com/facebookincubator/velox/blob/75cce7758dc3e6c3bbab826bf2423f118695ad57/velox/functions/sparksql/registration/RegisterMap.cpp#L32-L33)), and this repo's Velox has included it since apache/gluten#12270. - So the `transform_values` line in [registerPrestoVectorFunctions](https://github.com/apache/gluten/blob/1503e13b5fdd953fa46e20a91ee90d71c0494b22/cpp/velox/operators/functions/RegistrationAllFunctions.cc#L40-L44) is no longer needed: it [runs after the Spark registration](https://github.com/apache/gluten/blob/1503e13b5fdd953fa46e20a91ee90d71c0494b22/cpp/velox/operators/functions/RegistrationAllFunctions.cc#L75-L85) and only overwrites it with the same function. This PR removes it, and behavior does not change. ## How was this patch tested? ### Automated tests [d0d5105e01](https://github.com/apache/gluten/commit/d0d5105e01bf9cc67be654b9dac5f3ce3a96254d) with this change applied: ```bash ./build/mvn -o -B test -Pbackends-velox -Pspark-3.5 -pl backends-velox -Dspotless.check.skip=true -Dscalastyle.skip=true -Dcheckstyle.skip=true -Dtest=none -DfailIfNoTests=false -DwildcardSuites=org.apache.gluten.functions.ScalarFunctionsValidateSuite ``` ``` ScalarFunctionsValidateSuite: … - transform_values … Tests: succeeded 86, failed 0, canceled 0, ignored 0, pending 0 All tests passed. ``` ```bash ./build/mvn -o -B test -Pspark-ut -Pbackends-velox -Pspark-3.5 -pl gluten-ut/spark35 -Dspotless.check.skip=true -Dscalastyle.skip=true -Dcheckstyle.skip=true -Dtest=none -DfailIfNoTests=false -DwildcardSuites=org.apache.spark.sql.catalyst.expressions.GlutenHigherOrderFunctionsSuite,org.apache.spark.sql.GlutenDataFrameFunctionsSuite ``` ``` GlutenHigherOrderFunctionsSuite: … - TransformValues … GlutenDataFrameFunctionsSuite: … - transform values function - test primitive data types … - transform values function - test empty … - transform values function - test null values … - transform values function - test invalid functions … Tests: succeeded 158, failed 0, canceled 0, ignored 4, pending 0 All tests passed. ``` ## Was this patch authored or co-authored using generative AI tooling? Generated-by: Co-authored with Claude Code (claude-opus-5-5) <!-- Thank you for submitting a pull request! Here are some tips: 1. For first-time contributors, please read our contributing guide: https://github.com/apache/gluten/blob/main/CONTRIBUTING.md 2. If necessary, create a GitHub issue for discussion beforehand to avoid duplicate work. 3. If the PR is specific to a single backend, include [VL] or [CH] in the PR title to indicate the Velox or ClickHouse backend, respectively. 4. If the PR is not ready for review, please mark it as a draft. --> <!-- Thank you for submitting a pull request! Here are some tips: 1. For first-time contributors, please read our contributing guide: https://github.com/apache/gluten/blob/main/CONTRIBUTING.md 2. If necessary, create a GitHub issue for discussion beforehand to avoid duplicate work. 3. If the PR is specific to a single backend, include [VL] or [CH] in the PR title to indicate the Velox or ClickHouse backend, respectively. 4. If the PR is not ready for review, please mark it as a draft. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
