rdtr commented on PR #13207: URL: https://github.com/apache/gluten/pull/13207#issuecomment-6689768697
@philo-he This is the Gluten side of the ANSI plan agreed in https://github.com/facebookincubator/velox/issues/3869 with mbasmanova and rui-mo (https://github.com/facebookincubator/velox/issues/3869#issuecomment-6641765130). Velox Spark functions whose behavior depends on ANSI read `spark.ansi_enabled` from the session config, and when the mode Spark captured in an expression differs from the session, Gluten falls back to Spark (https://github.com/facebookincubator/velox/issues/3869#issuecomment-6607421212). This PR adds that fallback, and it sets how Gluten handles ANSI from here on, so I'd appreciate your review. It also fixes a wrong result with the default settings. `spark.gluten.sql.ansiFallback.enabled` looks only at the session, so a view created with ANSI on and read with ANSI off stays native, and `abs` in it wraps around where Spark throws `ARITHMETIC_OVERFLOW`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
