zhang-jianq commented on PR #13420: URL: https://github.com/apache/gluten/pull/13420#issuecomment-6678852207
> Thanks for expanding the tests to the constant, nested, and non-string forms. > > The PR description's "What changes" section still lists two changes that are no longer in the diff: "CI routing: `.github/workflows/flink.yml` clones the pinned velox4j branch" and "Docs: `gluten-flink/docs/Flink.md` build notes synced" — after the rebase onto main, the velox4j ref is managed by main's central `gluten-flink/velox4j-ref.txt` and the diff no longer touches either file. Please remove these two bullets. > > [?] (no anchor) 一般——body——The PR description's "What changes" section still lists two changes that are no longer in the diff: "CI routing: `.github/workflows/flink.yml` clones the pinned velox4j branch" and "Docs: `gluten-flink/docs/Flink.md` build notes synced" — after the rebase onto main, the velox4j ref is managed by main's central `gluten-flink/velox4j-ref.txt` and the diff no longer touches either file. Please remove these two bullets. @ggjh-159 Thanks for your review. It's fixed now. please review it again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
