rdtr commented on PR #13529:
URL: https://github.com/apache/gluten/pull/13529#issuecomment-6709542367

   @philo-he facebookincubator/velox#20058 is merged (e87e0ea70, 2026-11-06), 
so Velox `ceil` and `floor` now throw on a double outside the BIGINT range when 
`spark.sql.ansi.enabled` is true. Spark only does that since 4.3 (SPARK-58052). 
Up to 4.2 it saturates in both modes. After the next Velox bump, `SELECT 
ceil(1e20)` with ANSI on and `spark.gluten.sql.ansiFallback.enabled=false` will 
fail on Gluten, while Spark returns 9223372036854775807. dft-2026_11_06 doesn't 
have the change yet.
   
   This PR covers it: `Ceil` and `Floor` on a double count as ANSI off before 
4.3 (`AnsiModeMismatch.scala:57-60`), so they fall back in an ANSI session. 
`AnsiModeMismatchSuite` now checks that with 1e20 and -1e20 in a Parquet column 
("ceil and floor of a double fall back with ANSI on before Spark 4.3"). It 
would be good to land this before the bump. CI is green.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to