akshaytayal opened a new pull request, #13581:
URL: https://github.com/apache/gluten/pull/13581

   ## What changes are proposed in this pull request?
   
   Several Spark 4.3 UTs fail on Gluten only because of test infrastructure or 
because they assert vanilla operators (`HashAggregateExec`, `SortExec`, 
`FilterExec`, ...) that Gluten replaces with native ones.
   
   - `GlutenHiveSQLQuerySuiteBase`: override the new Spark 4.3 `classicSpark` 
hook so `SparkSessionBinderBase.afterEach` no longer NPEs.
   - Gluten sort aggregate test: use `useHashAggregateExec=false`, which 
replaces the removed `spark.sql.test.forceApplySortAggregate`.
   - Add Gluten variants that check the native operators, and run 
`GlutenCombineAdjacentAggregationSuite` with Gluten's two-phase aggregate merge 
disabled.
   - Update the TPC-DS v1.4 q16/q94/q95 golden plans for the new sort aggregate.
   
   Re-enabled / added tests:
   - `GlutenHiveSQLQuerySuite`: whole suite (6)
   - `GlutenWholeStageCodegenSuite`: 8 Gluten tests
   - `GlutenReplaceHashWithSortAggSuite`: 3 Gluten tests
   - `GlutenCombineAdjacentAggregationSuite`: suite enabled, 6 + 1 Gluten test
   - `GlutenPushDownLocalSortSuite`: suite enabled, 6 + 8 Gluten tests
   - `GlutenDataSourceV2CatalystRuntimeFilterSuite`: 6 Gluten tests
   - `GlutenMarkSingleTaskExecutionSuite`: 1 Gluten test
   - `GlutenJoinSuite`: 1 Gluten test
   - `GlutenTPCDSV1_4_PlanStability(WithStats)Suite`: q16, q94, q95 (6)
   
   Depends on #13520
   Related issue: #13517
   
   ## How was this patch tested?
   
   Test-only change; the Spark 4.3 UTs above run in CI.
   
   ## Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: GitHub Copilot CLI (Claude Opus 5.5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to