rdtr commented on issue #13433:
URL: https://github.com/apache/gluten/issues/13433#issuecomment-6728291044

   @akshaytayal FYI, #13207 was merged today. It falls back the scan when the 
`ignoreMissingFiles` read option differs from 
`spark.sql.files.ignoreMissingFiles` and re-enables the four SPARK-55857 
excludes, so the silent wrong result (conf `true`, option `false`: Gluten 
skipped the missing file where Spark fails) is gone for now.
   
   Once facebookincubator/velox#19840 lands and your change passes the option 
to native, it can drop that fallback (the check in `BasicScanExecTransformer`) 
and keep the scan native for this case. Happy to review it then.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to