philo-he commented on code in PR #13530:
URL: https://github.com/apache/gluten/pull/13530#discussion_r4508490789


##########
.github/workflows/velox_backend_x86.yml:
##########
@@ -1145,14 +1147,19 @@ jobs:
           --data $(realpath 
backends-velox/generated-native-benchmark/data_12_0_*_0.parquet),$(realpath 
backends-velox/generated-native-benchmark/data_12_0_*_1.parquet)
       - name: Run UDF test
         run: |
+          export SPARK_SCALA_VERSION=2.12
           yum install -y java-17-openjdk-devel
           export JAVA_HOME=/usr/lib/jvm/java-17-openjdk
           export PATH=$JAVA_HOME/bin:$PATH
           java -version
           # Depends on --build_example=ON.
-          $MVN_CMD test -Pspark-3.5 -Pbackends-velox -Pjava-17 -Piceberg 
-Pdelta -Ppaimon -DtagsToExclude=org.apache.gluten.tags.EnhancedFeaturesTest \
-          -DtagsToInclude=org.apache.gluten.tags.UDFTest \
-          -DargLine="-Dspark.test.home=/opt/shims/spark35/spark_home/"
+          $MVN_CMD install -Pspark-3.5 -Pbackends-velox -Pjava-17 -Piceberg 
-Pdelta -Ppaimon -pl backends-velox -am -DskipTests
+          for suite in VeloxUdfSuiteLocal VeloxUdfSuiteCluster; do
+            $MVN_CMD test -pl backends-velox -Pspark-3.5 -Pbackends-velox 
-Pjava-17 -Piceberg -Pdelta -Ppaimon 
-DtagsToExclude=org.apache.gluten.tags.EnhancedFeaturesTest \

Review Comment:
   Are `-Piceberg -Pdelta -Ppaimon` needed here? They only add lake 
dependencies to `backends-velox`, which `VeloxUdfSuite` doesn't use. If we drop 
them, drop them from the `install` and both `test` commands.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to