TianJialong commented on code in PR #13484: URL: https://github.com/apache/gluten/pull/13484#discussion_r4508936826
########## gluten-flink/ut/src/test/java/org/apache/gluten/table/runtime/stream/custom/HashFunctionsTest.java: ########## @@ -0,0 +1,256 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.gluten.table.runtime.stream.custom; + +import org.apache.gluten.table.runtime.stream.common.GlutenStreamingTestBase; + +import org.apache.flink.table.api.TableResult; +import org.apache.flink.types.Row; + +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Test; + +import java.util.Arrays; +import java.util.List; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatThrownBy; + +class HashFunctionsTest extends GlutenStreamingTestBase { + + // Digests pinned from Flink's own test suite for "" and "test" (lowercase hex + // over the string's UTF-8 bytes); the multi-byte row pins the encoding and the + // long row pins inputs past one digest block. + private static final String SHA224_EMPTY = + "d14a028c2a3a2bc9476102bb288234c415a2b01f828ea62ac5b3e42f"; + private static final String SHA256_EMPTY = + "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"; + private static final String SHA384_EMPTY = + "38b060a751ac96384cd9327eb1b1e36a21fdb71114be07434c0cc" + + "7bf63f6e1da274edebfe76f65fbd51ad2f14898b95b"; + private static final String SHA512_EMPTY = + "cf83e1357eefb8bdf1542850d66d8007d620e4050b5715dc83f4a921d36ce9ce47d" + + "0d13c5d85f2b0ff8318d2877eec2f63b931bd47417a81a538327af927da3e"; + private static final String SHA224_TEST = + "90a3ed9e32b2aaf4c61c410eb925426119e1a9dc53d4286ade99a809"; + private static final String SHA256_TEST = + "9f86d081884c7d659a2feaa0c55ad015a3bf4f1b2b0b822cd15d6c15b0f00a08"; + private static final String SHA384_TEST = + "768412320f7b0aa5812fce428dc4706b3cae50e02a64caa16a782249bfe8efc" + + "4b7ef1ccb126255d196047dfedf17a0a9"; + private static final String SHA512_TEST = + "ee26b0dd4af7e749aa1a8ee3c10ae9923f618980772e473f8819a5d4940e0db" + + "27ac185f8a0e1d5f84f88bc887fd67b143732c304cc5fa9ad8e6f57f50028a8ff"; + private static final String SHA224_UTF8 = + "b3f5c93d7b531d7e29266412f2c842f8a4b7286871f87d259c6eaf07"; + private static final String SHA256_UTF8 = + "beca6335b20ff57ccc47403ef4d9e0b8fccb4442b3151c2e7d50050673d43172"; + private static final String SHA384_UTF8 = + "5621250177cc297c02d4c7c2a950d541a52b5c478e1fa16ca5022316de898d7be5c" + + "66b16ad735295b48b84a47e986144"; + private static final String SHA512_UTF8 = + "4b28a152c8e203ebb52e099301041e3cf704a56190d3097ec8b086a0f9bfb4b9d533" + + "ce71fc3bcf374359e506dc5f17322ec3911eac8dd8f5b35308d938ba0c26"; + private static final String SHA224_LONG = + "e6e4a6be069cc9bead8b6050856d2b26da6b3f7efa0951e5fb3a54dd"; + private static final String SHA256_LONG = + "74e7e5bb9d22d6db26bf76946d40fff3ea9f0346b884fd0694920fccfad15e33"; + private static final String SHA384_LONG = + "ce6d4ea5442bc6c830bea1942d4860db9f7b96f0e9d2c3073ffe47a0e1166d95612d" + + "840ff15e5efdd23c1f273096da32"; + private static final String SHA512_LONG = + "95cadc34aa46b9fdef432f62fe5bad8d9f475bfbecf797d5802bb5f2937a85d93ce48" + + "57a6262b03834c01c610d74cd1215f9a466dc6ad3dd15078e3309a03a6d"; + private static final String SHA1_TEST = "a94a8fe5ccb19ba61c4c0873d391e987982fbbd3"; + private static final String SHA1_UTF8 = "dabaa5fe7c47fb21be902480a13013f16a1ab6eb"; + private static final String LONG_INPUT = "0123456789abcdefghijklmnopqrstuvwxyz"; + + @Override + @BeforeEach + public void before() throws Exception { + super.before(); + } Review Comment: @philo-he, thanks for the review. Unnecessary method is removed, pushed 0b73225. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
