philo-he commented on code in PR #13600: URL: https://github.com/apache/gluten/pull/13600#discussion_r4521993913
########## backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala: ########## Review Comment: Optional: the same "index argument" guards also remain in `genArrayExistsTransformer` and `genArrayForAllTransformer`. They can never trigger, because Spark's `exists` / `forall` only accept one-argument lambdas, so they could be removed here too to clear out the pattern. Fine to leave it for a separate PR if you prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
