luis4a0 commented on code in PR #13103: URL: https://github.com/apache/gluten/pull/13103#discussion_r4522638541
########## ep/build-velox/src/get-velox.sh: ########## @@ -25,7 +25,7 @@ RUN_SETUP_SCRIPT=ON ENABLE_ENHANCED_FEATURES=OFF # Developer use only for testing Velox PR. -UPSTREAM_VELOX_PR_ID="" +UPSTREAM_VELOX_PR_ID="19141" Review Comment: Resolved in https://github.com/luis4a0/gluten/commit/09cb152e487fc01dcdcd326aa1a59d66e59105a9. Current Gluten main now pins IBM Velox `dft-2026_11_06` (`6deac80271569277bf54b6d04547620c17438348`), which contains the landed implementations from https://github.com/facebookincubator/velox/pull/19141 and https://github.com/facebookincubator/velox/pull/19480. I merged current main into this branch and removed the temporary dependency gate; `ep/build-velox/src/get-velox.sh` now matches main and is absent from the effective PR diff. Fresh validation against the normal pin passed: native 3/3, API 2/2, Spark 4.1 SQL 5/5 on JDK 17 and JDK 21, and Spark 4.2 SQL 5/5 on JDK 17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
