wud-if commented on code in PR #13412: URL: https://github.com/apache/gluten/pull/13412#discussion_r4536219801
########## gluten-flink/planner/src/main/java/org/apache/gluten/rexnode/functions/NumericOnlyRexCallConverter.java: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.gluten.rexnode.functions; + +import org.apache.gluten.rexnode.RexConversionContext; +import org.apache.gluten.rexnode.RexNodeConverter; +import org.apache.gluten.rexnode.TypeUtils; +import org.apache.gluten.rexnode.ValidationResult; + +import io.github.zhztheplayer.velox4j.expression.CallTypedExpr; +import io.github.zhztheplayer.velox4j.expression.TypedExpr; + +import org.apache.calcite.rex.RexCall; + +import java.util.List; + +/** + * Converter for functions whose velox registrations cover numeric operands only. Non-numeric + * operands are rejected here so conversion fails loudly at planning time (e.g. the datetime form + * FLOOR(ts TO DAY) carries a SYMBOL literal that maps to VARCHAR and would otherwise produce an + * unresolvable velox signature at runtime). + */ +class NumericOnlyRexCallConverter extends BaseRexCallConverter { + + public NumericOnlyRexCallConverter(String functionName) { + super(functionName); + } + + @Override + public ValidationResult isSuitable(RexCall callNode, RexConversionContext context) { + try { + boolean allNumeric = + callNode.getOperands().stream() + .allMatch( + arg -> TypeUtils.isNumericOrDecimalType(RexNodeConverter.toType(arg.getType()))); + if (!allNumeric) { + return ValidationResult.failure( + String.format( + "Numeric-only operation requires all operands to be numeric or decimal types, but found: %s", + getFunctionProtoTypeName(callNode))); + } + } catch (RuntimeException e) { + // Operand types without a velox mapping are rejected at planning + // time rather than blowing up in toType. + return ValidationResult.failure( + String.format( + "Numeric-only operation requires all operands to be numeric or decimal types, but found: %s", + getFunctionProtoTypeName(callNode))); Review Comment: Done in a261e253c — the non-numeric branch and the `toType`-probe catch block now share a single `notNumericFailure` helper, so the message lives in one place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
