JkSelf commented on issue #13253:
URL: https://github.com/apache/gluten/issues/13253#issuecomment-6793078595

   @anshulbaliga7 Thanks for your great working. 
   
   We maintain the [HashBuild logic 
](https://github.com/apache/gluten/blob/main/cpp/velox/operators/hashjoin/HashTableBuilder.cc)
 in gluten cpp to pre-build the hash table. So it can easily cause our gluten 
unit tests failing if upstream velox change the logic of HashBuild in our daily 
rebase. And this option can make us fallback to original code path and not 
breaking the rebase work.
   
   Currently i am working on removing this HashBuild logic in gluten by running 
a fake HashJoin job to build hash table in gluten side in #13216.  And we can 
consider to remove this option after #13216 merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to