marin-ma commented on code in PR #13548:
URL: https://github.com/apache/gluten/pull/13548#discussion_r4537114729
##########
cpp/velox/shuffle/VeloxHashShuffleWriter.cc:
##########
@@ -229,12 +229,9 @@ arrow::Result<std::shared_ptr<arrow::Buffer>>
VeloxHashShuffleWriter::generateCo
const facebook::velox::IndexRange allRows{0, vector->size()};
serializer->append(vector, folly::Range(&allRows, 1));
auto serializedSize = serializer->maxSerializedSize();
- auto flushBuffer = complexTypeFlushBuffer_[0];
Review Comment:
@LuciferYang Thanks a lot for digging into this and the clear explanation. I
checked the code and you're right that the flush buffers for complex types do
not respect the `reuseBuffers` flag.
I agree with the cleanup as it doesn't change the current behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]