taiyang-li commented on code in PR #13486:
URL: https://github.com/apache/gluten/pull/13486#discussion_r4538765849
##########
gluten-ut/spark41/src/test/scala/org/apache/spark/sql/execution/GlutenLogicalPlanTagInSparkPlanSuite.scala:
##########
@@ -96,9 +96,12 @@ class GlutenLogicalPlanTagInSparkPlanSuite
assert(plan.getTagValue(SparkPlan.LOGICAL_PLAN_TAG).isEmpty)
// Gluten infrastructure nodes (no corresponding logical plan)
- case _: WholeStageTransformer | _: InputIteratorTransformer | _:
ColumnarInputAdapter |
- _: VeloxResizeBatchesExec =>
+ case _: WholeStageTransformer | _: InputIteratorTransformer | _:
ColumnarInputAdapter =>
// These are Gluten-specific wrapper nodes without logical plan links.
+ case p: ColumnarToColumnarExec
Review Comment:
We can further simplify the resize handling in
`GlutenLogicalPlanTagInSparkPlanSuite` for Spark 4.0, 4.1 and 4.2 by deleting
the new `ColumnarToColumnarExec` case with the two class-name comparisons. Its
body is empty, just like the final default case, and neither resize
implementation matches `isGlutenScanPlanTree`. Both paths then recurse into
`children` and `subqueries`, so the dedicated resize case does not add any
checks.
The necessary compile-time adaptation is already covered by removing the
original `VeloxResizeBatchesExec` pattern. The remaining infrastructure case
can simply stay as:
```scala
case _: WholeStageTransformer | _: InputIteratorTransformer | _:
ColumnarInputAdapter =>
```
This keeps the shared changes limited to removing compile-time Velox
dependencies, without introducing backend class-name comparisons. The existing
recursive logical-plan checks remain intact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]