felipepessoto commented on code in PR #13560:
URL: https://github.com/apache/gluten/pull/13560#discussion_r4540999861


##########
gluten-arrow/pom.xml:
##########
@@ -278,4 +288,28 @@
     
<testOutputDirectory>target/scala-${scala.binary.version}/test-classes</testOutputDirectory>
   </build>
 
+  <profiles>
+    <profile>
+      <id>jni-test</id>
+      <properties>
+        
<gluten.jni.test.lib.dir>${project.basedir}/../cpp/build/test-libs</gluten.jni.test.lib.dir>
+      </properties>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-surefire-plugin</artifactId>
+            <configuration>
+              <excludes combine.self="override"/>
+              <failIfNoTests>true</failIfNoTests>
+              <forkedProcessTimeoutInSeconds>60</forkedProcessTimeoutInSeconds>

Review Comment:
   Fixed in 7d8d7fbc. Moved the JNI-specific exclusion into an 
active-by-default module profile that appends to inherited exclusions. Enabling 
`jni-test` disables that profile, so it no longer clears the Surefire exclusion 
list.
   
   Verified with exclusions from both parent `pluginManagement` and parent 
`build/plugins`: the old configuration ran the deliberately excluded tests, 
while the updated configuration keeps them excluded and passes all four JNI 
cases. Normal builds still exclude the JNI fixture, and a missing bridge still 
fails when `jni-test` is enabled.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to