philo-he commented on PR #13389:
URL: https://github.com/apache/gluten/pull/13389#issuecomment-6816302732

   > For get_timestamp that change is already open in 
https://github.com/facebookincubator/velox/pull/19333. It reads the config in 
initialize() and throws on a parse error when ANSI is on, like unix_timestamp. 
With it, Gluten keeps mapping GetTimestamp to get_timestamp and needs neither 
the overlay nor a new name. When the mode captured in the expression differs 
from the session (a view or a DataFrame created in the other mode), 
https://github.com/apache/gluten/pull/13529 falls back to Spark.
   
   @rdtr, @Mariamalmesfer, this sounds good to me. I was wondering whether 
overlay is suitable here. If adding ANSI support for a function only requires 
small code changes in Velox, and Velox community would accept the changes, I 
feel it seems better to make the changes in Velox. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to