zhouyuan commented on code in PR #12831:
URL: https://github.com/apache/gluten/pull/12831#discussion_r4549917802
##########
cpp/velox/compute/VeloxBackend.cc:
##########
@@ -157,6 +158,11 @@ void VeloxBackend::init(
FLAGS_logtostderr = true;
google::InitGoogleLogging("gluten");
+ // Make sure the statically linked OpenSSL can find trusted certificates
before any filesystem creates an HTTP client.
+ // This may call setenv(), which is not safe against concurrent
getenv()/setenv() calls from other threads, so it is
+ // done here, once per process, before the memory manager, the filesystems
and the other components are set up.
+ ensureTlsTrustStore();
Review Comment:
nit: could we wrap this with `ENABLE_GLUTEN_VCPKG` so the dynamic build will
not be impacted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]