Copilot commented on code in PR #13632:
URL: https://github.com/apache/gluten/pull/13632#discussion_r4561600670


##########
dev/release/build-release.sh:
##########
@@ -25,9 +25,8 @@ cd ${GLUTEN_HOME}
 ./dev/builddeps-veloxbe.sh --enable_vcpkg=ON --build_arrow=OFF 
--build_tests=OFF --build_benchmarks=OFF \
                            --build_examples=OFF --enable_s3=ON --enable_gcs=ON 
--enable_hdfs=ON --enable_abfs=ON
 
-sudo curl -Lo /etc/yum.repos.d/corretto.repo 
https://yum.corretto.aws/corretto.repo
-sudo yum install -y java-17-amazon-corretto-devel
-export JAVA_HOME=/usr/lib/jvm/java-17-amazon-corretto
+sudo yum install -y java-17-openjdk-devel

Review Comment:
   Now that the workflow runs *inside* the container (rather than via `docker 
run`), the job commonly executes as root and images often do not include 
`sudo`. Using `sudo` here can cause the pipeline to fail with `sudo: command 
not found`. Prefer running `yum` directly, or gate `sudo` usage (e.g., use 
`sudo` only when available / when not already root).



##########
.github/workflows/build_release.yml:
##########
@@ -24,17 +24,13 @@ on:
 jobs:
   build-velox-backend-release:
     runs-on: ubuntu-latest
+    container: apache/gluten:vcpkg-almalinux-8-gcc13
     steps:
       - uses: actions/checkout@v7
       - name: Build
         run: |
-          docker pull apache/gluten:vcpkg-almalinux-8-gcc13
-          docker run -v $GITHUB_WORKSPACE:/workspace -w /workspace 
apache/gluten:vcpkg-almalinux-8-gcc13 bash -c "
-            set -e
-            yum install bison -y
-            cd /workspace
-            bash dev/release/build-release.sh
-          "
+          source /opt/rh/gcc-toolset-13/enable
+          ./dev/release/build-release.sh

Review Comment:
   The previous workflow explicitly installed `bison` before running the build; 
that installation step was removed when switching to `container:`. If `bison` 
is still required by `build-release.sh` or its dependency build steps, the 
workflow may regress. Either re-add a package install step here or ensure the 
container image already includes `bison` (and document that assumption).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to