shivadarshan-devadiga opened a new pull request, #13637:
URL: https://github.com/apache/gluten/pull/13637

   ## What changes are proposed in this pull request?
   
   Fixes #13636
   
   Related to #12856 / #13405.
   
   The ClickHouse Hive SQL query suite created persistent Hive tables and 
dropped them only after the assertions ran, with 
`spark.sessionState.catalog.dropTable(...)` outside `withTable` or a `finally`, 
so a failed assertion skipped it. Two cases also started with a `DROP TABLE IF 
EXISTS`. This is the same problem #13405 fixed in `GlutenHiveSQLQuerySuite`.
   
   This PR wraps each of the three cases (`5182`, `5249`, `GLUTEN-7116`) in 
`withTable(...)` for the tables it creates, and removes the manual drops and 
the unused `TableIdentifier` import, in all five modules (`gluten-ut/spark34`, 
`spark35`, `spark40`, `spark41`, `spark42`). The `GLUTEN-7116` case also 
changes `create table if not exists` to `create table`: with `withTable` 
cleaning up, a leftover table should fail the create rather than be reused.
   
   ## How was this patch tested?
   
   - Every created table is listed in its case's `withTable`, and no manual 
drop or `TableIdentifier` is left.
   - The five modules compile, including their test sources, and 
`spotless:check` passes for each of them.
   - The suite runs on the ClickHouse backend, so CI runs it.
   
   ## Was this patch authored or co-authored using generative AI tooling?
   
   Co-authored by: Claude Sonnet 4.5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to