rui-mo commented on code in PR #13613:
URL: https://github.com/apache/gluten/pull/13613#discussion_r4569685530


##########
gluten-substrait/src/main/scala/org/apache/gluten/config/GlutenConfig.scala:
##########
@@ -613,6 +612,21 @@ object GlutenConfig extends ConfigRegistry {
           nativeConfMap
             .put(SQLConf.LEGACY_TIME_PARSER_POLICY.key, 
v.toUpperCase(Locale.ROOT)))
 
+    // Spark accepts this value in any case, and native code compares it in 
upper case.
+    nativeConfMap.put(
+      SQLConf.MAP_KEY_DEDUP_POLICY.key,
+      conf
+        .getOrElse(
+          SQLConf.MAP_KEY_DEDUP_POLICY.key,
+          SQLConf.MAP_KEY_DEDUP_POLICY.defaultValueString)
+        .toUpperCase(Locale.ROOT)
+    )
+
+    // Spark accepts the codec name in any case, and Velox matches it in lower 
case.
+    conf

Review Comment:
   Would it make sense to make name matching case-insensitive in Velox or 
elsewhere, so we can avoid having to use `toUpperCase` in some places and 
`toLowerCase` in others?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to