felipepessoto commented on code in PR #13148:
URL: https://github.com/apache/gluten/pull/13148#discussion_r4575798198


##########
gluten-arrow/src/main/java/org/apache/gluten/vectorized/ColumnarBatchOutIterator.java:
##########
@@ -153,6 +153,12 @@ protected RuntimeException translateException(Exception e) 
{
         return schemaEx;
       }
     }
+    // A GlutenException raised by native/nested code is already translated; 
return it
+    // as-is rather than nesting it in another GlutenException. The 
schema-conversion
+    // special case above still runs first, so a schema error keeps its 
dedicated type.
+    if (e instanceof GlutenException) {

Review Comment:
   Thanks for flagging this. I’ve rebased 
[#13135](https://github.com/apache/gluten/pull/13135) onto this change, keeping 
native-cast and schema translation **before** the generic `GlutenException` 
pass-through.
   
   The iterator regressions now explicitly protect that ordering and check 
same-instance pass-through for existing exceptions, while retaining 
cause-preserving wrapping for raw exceptions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to